Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soloseng/rename-utils-contract #11276

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Soloseng/rename-utils-contract #11276

merged 6 commits into from
Nov 20, 2024

Conversation

soloseng
Copy link
Contributor

Description

Renamed Utils contract to make it clear that it includes the foundry test contract

Other changes

updated any imports

Tested

unit tested

Related issues

@soloseng soloseng requested a review from a team as a code owner November 19, 2024 21:21
@soloseng soloseng self-assigned this Nov 19, 2024
m-chrzan
m-chrzan approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@m-chrzan m-chrzan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great to see all the unnecessary imports disappear. Should we do the same with utils08?

packages/protocol/test-sol/testWithUtils.sol Outdated Show resolved Hide resolved
@soloseng
Copy link
Contributor Author

Should we do the same with utils08

I did not, because it does not inherit the Test contract.

@soloseng soloseng enabled auto-merge (squash) November 20, 2024 17:05
@soloseng soloseng merged commit adc0960 into release/core-contracts/12 Nov 20, 2024
40 of 44 checks passed
@soloseng soloseng deleted the soloseng/rename-utils-contract branch November 20, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-chrzan m-chrzan m-chrzan approved these changes

Assignees

@soloseng soloseng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soloseng @m-chrzan